Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove interrupt button from the notebook editor toolbar. #11359

Merged
merged 3 commits into from
Sep 13, 2022
Merged

Remove interrupt button from the notebook editor toolbar. #11359

merged 3 commits into from
Sep 13, 2022

Conversation

rebornix
Copy link
Member

Upstream issue microsoft/vscode#128245 and PR microsoft/vscode#160738. This PR should only be merged after VS Code changes is out.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for feature-requests.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@rebornix rebornix self-assigned this Sep 12, 2022
IanMatthewHuff
IanMatthewHuff approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is funky in the build here? Doesn't seem related to your change though.

@rebornix rebornix merged commit fd9f9d9 into main Sep 13, 2022
@rebornix rebornix deleted the rebornix/remoteb-interrupt-from-notebook-toolbar branch September 13, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

Assignees

@rebornix rebornix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rebornix @IanMatthewHuff